Skip to content

Fix public-header and runner-contract CI failures - #1566

Open
bmehta001 wants to merge 2 commits into
mainfrom
bhamehta/fix-icdsfactory-header
Open

bmehta001 wants to merge 2 commits into
mainfrom
bhamehta/fix-icdsfactory-header

Conversation

@bmehta001

@bmehta001 bmehta001 commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

Why

ICdsFactory.hpp uses uint8_t but does not include its declaration. Some consumers, including the Linux jobs in microsoft/cpp_client_telemetry_modules#375, fail unless another header happens to include it first.

The build-runner contract fixture can also select both concurrent processes as its first child on some runners. Use shell noclobber to make that selection atomic.

This extracts the same two independent CI fixes already present in #1561 into an independently mergeable PR. Once this is independently reviewed and merged, the private CI can update its public SDK pin to an approved merged commit and validate its matrix before microsoft/cpp_client_telemetry_modules#375 is merged. That private PR must still merge before #1561, which changes submodule initialization.

Validation

  • Standalone public-header gates passed with GCC and Clang on WSL, and Visual Studio 2026 on Windows, including exception-disabled configurations. The existing VariantType.hpp implementation-fragment exclusion remains unchanged.
  • Runner contract tests passed ten consecutive times on WSL; the identical fix also passed in Harden CI credentials and fix Dependabot submodule failures #1561 CI.
  • Full repository misspell workflow and git diff --check passed.

Make the public header self-contained so consumers and the private module CI can compile without relying on transitive includes.

Files: lib/include/public/ICdsFactory.hpp

Co-authored-by: Copilot <[email protected]>
Copilot-Session: e5009227-6b49-4803-8153-63d8d94037e3
Use an atomic noclobber operation so runner contract tests do not depend on mkdir behavior under contention.

Files: tests/build-runner-tests.py

Co-authored-by: Copilot <[email protected]>
Copilot-Session: e5009227-6b49-4803-8153-63d8d94037e3
@bmehta001 bmehta001 changed the title Make the public factory header self-contained Fix public-header and runner-contract CI failures Nov 19, 2026
@bmehta001 bmehta001 self-assigned this Nov 20, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant