Repository navigation
Conversation
Make the public header self-contained so consumers and the private module CI can compile without relying on transitive includes. Files: lib/include/public/ICdsFactory.hpp Co-authored-by: Copilot <[email protected]> Copilot-Session: e5009227-6b49-4803-8153-63d8d94037e3
Use an atomic noclobber operation so runner contract tests do not depend on mkdir behavior under contention. Files: tests/build-runner-tests.py Co-authored-by: Copilot <[email protected]> Copilot-Session: e5009227-6b49-4803-8153-63d8d94037e3
This was referenced Nov 19, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
ICdsFactory.hppusesuint8_tbut does not include its declaration. Some consumers, including the Linux jobs in microsoft/cpp_client_telemetry_modules#375, fail unless another header happens to include it first.The build-runner contract fixture can also select both concurrent processes as its first child on some runners. Use shell noclobber to make that selection atomic.
This extracts the same two independent CI fixes already present in #1561 into an independently mergeable PR. Once this is independently reviewed and merged, the private CI can update its public SDK pin to an approved merged commit and validate its matrix before microsoft/cpp_client_telemetry_modules#375 is merged. That private PR must still merge before #1561, which changes submodule initialization.
Validation
VariantType.hppimplementation-fragment exclusion remains unchanged.git diff --checkpassed.